Skip to content

[FrameworkBundle] Add support to set BinaryFileResponse::trustXSendfileTypeHeader over config #45724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

[FrameworkBundle] Add support to set BinaryFileResponse::trustXSendfileTypeHeader over config #45724

merged 1 commit into from
Apr 12, 2022

Conversation

alexander-schranz
Copy link
Contributor

@alexander-schranz alexander-schranz commented Mar 12, 2022 •
edited
Loading

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #37561
License MIT
Doc PR symfony/symfony-docs#...

Similar to http overrides and trusted proxies, this way it is possible to control the trustxsendfileheader configuration:

framework:
    trust_x_sendfile_type_header: true

@carsonbot carsonbot added this to the 6.1 milestone Mar 12, 2022
@alexander-schranz alexander-schranz force-pushed the feature/xsendfile-configuration branch 2 times, most recently from daad2ae to fd9ac27 Compare March 12, 2022 20:38
@alexander-schranz alexander-schranz mentioned this pull request Mar 12, 2022
Closed
@alexander-schranz alexander-schranz changed the title Add support to set trustxsendfilehader over framework configuration [FrameworkBundle] Add support to set trustxsendfilehader over framework configuration Mar 14, 2022
@alexander-schranz alexander-schranz changed the title [FrameworkBundle] Add support to set trustxsendfilehader over framework configuration [FrameworkBundle] Add support to set binaryfileresponse trustxsendfileheader over framework configuration Mar 23, 2022
@alexander-schranz alexander-schranz changed the title [FrameworkBundle] Add support to set binaryfileresponse trustxsendfileheader over framework configuration [FrameworkBundle] Add support to set BinaryFileResponse::trustXSendfileTypeHeader over framework configuration Mar 23, 2022
@alexander-schranz alexander-schranz force-pushed the feature/xsendfile-configuration branch from fd9ac27 to bc112ae Compare March 23, 2022 18:39
@alexander-schranz alexander-schranz changed the title [FrameworkBundle] Add support to set BinaryFileResponse::trustXSendfileTypeHeader over framework configuration [FrameworkBundle] Add support to set BinaryFileResponse::trustXSendfileTypeHeader over config Mar 23, 2022
@alexander-schranz alexander-schranz force-pushed the feature/xsendfile-configuration branch from ab6d0ad to 3a6bff4 Compare April 10, 2022 13:08
@carsonbot carsonbot changed the title [FrameworkBundle] Add support to set BinaryFileResponse::trustXSendfileTypeHeader over config Add support to set BinaryFileResponse::trustXSendfileTypeHeader over config Apr 11, 2022
@alexander-schranz alexander-schranz changed the title Add support to set BinaryFileResponse::trustXSendfileTypeHeader over config [FrameworkBundle] Add support to set BinaryFileResponse::trustXSendfileTypeHeader over config Apr 11, 2022
@fabpot fabpot force-pushed the feature/xsendfile-configuration branch from 3a6bff4 to 6cb54f5 Compare April 12, 2022 06:01
@fabpot
Copy link
Member

fabpot commented Apr 12, 2022

Thank you @alexander-schranz.

@fabpot fabpot merged commit 98dc2ec into symfony:6.1 Apr 12, 2022
@fabpot fabpot mentioned this pull request Apr 12, 2022
Closed
@alexander-schranz alexander-schranz deleted the feature/xsendfile-configuration branch April 12, 2022 08:32
@fabpot fabpot mentioned this pull request Apr 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Feature Status: Reviewed
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

Add possibility to trustXSendfileTypeHeader by environment variable
4 participants
@alexander-schranz @fabpot @nicolas-grekas @carsonbot