[Config] Fix using null values with config builders #45789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| class ReceivingConfig | ||
| { | ||
| private $priority; | ||
| private $color; | ||
| private $_usedProperties = []; |
There was a problem hiding this comment.
we don't use underscores in property names
There was a problem hiding this comment.
@nicolas-grekas This is to avoid collision with configuration proprieties (->scalarNode('used_properties')), same as with _extraKeys.
Sorry, I accidentally resolved this.
There was a problem hiding this comment.
Got it, thanks for the explanation.
nicolas-grekas
approved these changes
Mar 21, 2022
stof
reviewed
Mar 21, 2022
| $this->scalarNode = $value['scalar_node']; | ||
| unset($value['scalar_node']); | ||
| } | ||
|
|
||
| if (isset($value['scalar_node_with_default'])) { |
There was a problem hiding this comment.
shouldn't this use array_key_exists to allow passing null ?
There was a problem hiding this comment.
@stof Yep, missed that one, tnx. Fixed https://github.com/symfony/symfony/compare/e214761c573ecc980b5d1b5e3c4dff12f8a6933d..1264225f4ebc535deec491737b70d9bc1d84dc98
e214761 to
1264225
Compare
|
Thank you @HypeMC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated config builders will no longer discard
nullvalues.