Skip to content

[Notifier] [OvhCloud] Add no_stop_clause to DSN #45951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alamirault
Copy link
Contributor

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #45932
License MIT

This PR allow to configure no_stop_clause (default false) for OvhCloud. Was always false before.

@alamirault alamirault requested a review from OskarStark as a code owner April 5, 2022 20:25
@carsonbot carsonbot added this to the 6.1 milestone Apr 5, 2022
@OskarStark OskarStark changed the title [Notifier] OvhCloud Add no_stop_clause to DSN [Notifier][OvhCloud] Add no_stop_clause to DSN Apr 5, 2022
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after my comment

@carsonbot carsonbot changed the title [Notifier][OvhCloud] Add no_stop_clause to DSN [Notifier] [OvhCloud] Add no_stop_clause to DSN Apr 5, 2022
@OskarStark OskarStark requested a review from fabpot April 5, 2022 20:52
@fabpot fabpot force-pushed the 45932-configure-ovhcloud-no-stop-option branch from 9f51b17 to 0999ac0 Compare April 8, 2022 05:03
@fabpot
Copy link
Member

fabpot commented Apr 8, 2022

Thank you @alamirault.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Notifier] [OvhCloud] Adding a no_stop_clause option
6 participants