[Mailer] Return-Path has higher priority for envelope address than From address #45992
Conversation
tpetry
commented
Apr 11, 2022
•
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #41322 |
| License | MIT |
| Doc PR | - |
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
It looks like you unchecked the "Allow edits from maintainer" box. That is fine, but please note that if you have multiple commits, you'll need to squash your commits into one before this can be merged. Or, you can check the "Allow edits from maintainers" box and the maintainer can squash for you. Cheers! Carsonbot |
b2e75df to
4c98940
Compare
|
This should be on 4.4 instead. |
|
Ok, I'll rebase it onto 4.4 😉 |
4c98940 to
7dd5c60
Compare
|
@fabpot Can you re-run the workflows? I missed changing the new base branch information in the Github Pull Request setting. |
|
This is great! I am having the issue with Laravel 9 not setting the Return Path on the sent email correctly. It's always the sender email. Thanks for the PR! |
7dd5c60 to
4945059
Compare
|
Thank you @tpetry. |
…n SES API transport (xabbuh) This PR was merged into the 5.4 branch. Discussion ---------- [Mailer] prefer From header over Return-Path as sender in SES API transport | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | related to the changes made in #45992 | License | MIT | Doc PR | Commits ------- c6174eb prefer From header over Return-Path as sender in SES API transport