Skip to content

[FrameworkBundle] Fix env resolution in lock configuration #46013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 12, 2022
Merged

[FrameworkBundle] Fix env resolution in lock configuration #46013

merged 1 commit into from
Apr 12, 2022

Conversation

jderusse
Copy link
Member

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets /
License MIT
Doc PR /

Fix wrong value injected in lock factory. See #44155 (comment)

@carsonbot carsonbot changed the title Fix env resolution in lock configuration [FrameworkBundle] Fix env resolution in lock configuration Apr 12, 2022
@carsonbot carsonbot added this to the 4.4 milestone Apr 12, 2022
@jderusse jderusse mentioned this pull request Apr 12, 2022
Merged
@nicolas-grekas
Copy link
Member

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 63de80b into symfony:4.4 Apr 12, 2022
@stof
Copy link
Member

stof commented Apr 12, 2022

sharing the services based on the fact that they share the same resolved DSN at build time could also create such bugs. Instead, the $storeDefinitionId should probably check that they rely on the same env placeholders to be sure that the runtime resolution will still be the same (or not share services at all)

@jderusse jderusse deleted the fix-lock branch April 12, 2022 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jderusse @nicolas-grekas @stof @carsonbot