Skip to content

[Form] do not use mocks in tests when not necessary #46095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2022
Merged

[Form] do not use mocks in tests when not necessary #46095

merged 1 commit into from
Apr 18, 2022

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 18, 2022

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

continuation of #46030 for 5.4+

@xabbuh xabbuh added this to the 5.4 milestone Apr 18, 2022
@xabbuh xabbuh requested a review from yceruto as a code owner April 18, 2022 12:23
@carsonbot carsonbot changed the title [WIP][Form] do not use mocks in tests when not necessary [Form] [WIP] do not use mocks in tests when not necessary Apr 18, 2022
@xabbuh xabbuh changed the title [Form] [WIP] do not use mocks in tests when not necessary [Form] do not use mocks in tests when not necessary Apr 18, 2022
@xabbuh
Copy link
Member Author

xabbuh commented Apr 18, 2022

Status: Needs Review

@chalasr
Copy link
Member

chalasr commented Apr 18, 2022

Thank you @xabbuh.

@chalasr chalasr merged commit cb6e26f into symfony:5.4 Apr 18, 2022
@xabbuh xabbuh deleted the form-tests-mock branch April 18, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto yceruto approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Form Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @chalasr @yceruto @carsonbot