Skip to content

[String] Fix ansi escape sequences regex #46106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

fancyweb
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? -
Tickets -
License MIT
Doc PR -

It doesn't change much but I think it's a mistake.
0x40-\x7E means one character among 0, x and 4 or one character from 0 to ~ (ascii range) but what is intended is one character from @ to ~ (ascii range).

@nicolas-grekas
Copy link
Member

Good catch, thanks @fancyweb.

@nicolas-grekas nicolas-grekas merged commit 7f37797 into symfony:5.4 Apr 19, 2022
@fancyweb fancyweb deleted the string/fix-regex branch April 19, 2022 13:24
This was referenced Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants