[DependencyInjection] Rename #[InnerService] to #[MapDecorated]
#46112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#[InnerService] to `#[Decorated] #[InnerService] to #[Decorated]
src/Symfony/Component/DependencyInjection/Attribute/Decorated.php
Outdated
Show resolved
Hide resolved
#[InnerService] to #[Decorated]#[InnerService] to #[MapDecorated]
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/AutowirePass.php
Outdated
Show resolved
Hide resolved
512812a to
1c7a20a
Compare
nicolas-grekas
approved these changes
Apr 21, 2022
fabpot
approved these changes
Apr 22, 2022
|
Thank you @chalasr. |
|
Just for understanding: why |
Merged
|
"map" stands for "inject" or "wire", or "autowire" to be more precise - but using a more compact word. |
|
Ah OK, I was confused by the "other" kind of map (key=>value storage). Thanks for the insights. |
|
this works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When talking about the decorator pattern outside of Symfony, the term
inneris pretty much (if not totally) inexistent. Worse, it makes the concept harder to explain. Take "there is a decorator and a decorated object" vs "there is a decorator and an inner object": using the later form, one has to explain both what is the decorator and what is the inner. While using the former, explaining what the decorator makes it obvious what the decorated is.I propose to take the addition of this attribute as an opportunity to start making this special term go away.
Also I removed the
Servicesuffix. It is tempting to keep it for explicitness, but it feels kinda redundant and AFAIK no other core attribute has such redundant suffix, maybe because their namespace is enough to indicate their target.