[Cache] Prevent fatal errors on php 8 when running concurrently with TagAwareAdapter v6.1 #46143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84a0b75 to
22c3afd
Compare
| @@ -430,6 +433,10 @@ private function getTagVersions(array $tagsByKey, array &$invalidatedTags = []) | |||
| if (isset($invalidatedTags[$tag])) { | |||
| $invalidatedTags[$tag] = $version->set(++$tagVersions[$tag]); | |||
| } | |||
| if (!\is_int($tagVersions[$tag])) { | |||
There was a problem hiding this comment.
on the line above, we have a ++ on this entry, shouldn't we check for this earlier?
There was a problem hiding this comment.
++ operator works with strings
Although it not always changes string values (and thus no invalidation occurs in those cases) but at least it doesn't do the fatality.
|
Can we add a test to prevent future regressions? |
22c3afd to
0f085c4
Compare
|
I've added a few tests. Please let me know if they make sense. |
0f085c4 to
33790b3
Compare
…TagAwareAdapter v6.1
33790b3 to
33f8496
Compare
|
Thank you @sbelyshkin. |
This was referenced Apr 27, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix prevents fatal errors which may arise during rolling updates when TagAwareAdapter is upgraded from versions prior to 5.4 to the latest 6.1. TypeErrors occur because of different value types for tag versions and rules for numeric strings in php 8.x https://www.php.net/manual/en/language.types.numeric-strings.php