-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
Modify processing of uploaded files to be compatible with PHP 8.1 #46149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
should be merged in 4.4 actually. Can you rebase your branch on top of 4.4 (and change the PR target branch then) ? |
Remove full_path from keys before check Keep logic the same as in src/Symfony/Component/HttpFoundation/FileBag.php
90b44c8
to
a5cc1e1
Compare
Branch is rebased on top of 4.4 |
Thank you @p-golovin. |
Remove full_path from keys before check
Keep logic the same as in src/Symfony/Component/HttpFoundation/FileBag.php