@xavren still up to finish this one? Can you figure out a failing test case?

@nicolas-grekas sorry for the delay, we had some new priorities and forgot to follow this issue.

You are right, this is not the issue, but the bug exists as demonstrated by this https://github.com/xavren/symfony-translator-bug/blob/master/src/Command/TestCommand.php

Code

$output->writeln($this->translator->trans('test', ['name' => 'World']));
$output->writeln($this->translator->trans('test', ['name' => 'World'], 'messages+intl-icu'));
$output->writeln($this->translator->trans('test', ['name' => 'World'], 'messages'));

Result is

php bin/console app:test
Hello %name%
Hello %World%
Hello %name%

It seems that MessageCatalogue loading messages has an issue but cannot spot it and did not find any tests :/

For the debug, here is the cache file

var/cache/dev/translations/catalogue.en.bBuRKVV.php

<?php

use Symfony\Component\Translation\MessageCatalogue;

$catalogue = new MessageCatalogue('en', array (
  'messages+intl-icu' => 
  array (
    'test' => 'Hello %name%',
  ),
));


return $catalogue;

Well, using %name% in a catalogue that has the intl suffix is not replaced at all and this is expected, as this is not a placeholder at all in the ICU message format.

Completly ok with that, but you can see the content of my translations files

Result is completly mixed up

@xavren The legacy format replaces whatever you pass as key. so to replace %name%, you need to pass %name% as key, not name (as part if the Intl ICU message format migration, % are trimmed from the placeholder name, but they are not added automatically)

@stof, the idea was to show mixup catalogue data, we have legacy data in intl-icu domain, that override intl-icu data, formatted by intlFormatter.
If you tell me this is what's expected, i'll close this issue

you should not have legacy data in your intl-icu catalogue. That should go in the non-suffixed catalogue for that domain. Putting legacy data in the catalogue that is meant to contain ICU format will indeed not work, and that's totally expected.

Hi @stof and @nicolas-grekas, i modified my PR adding tests that demonstrate the issue (hopefully)

public function testIntlDomainOverlapseWithIntlResourceBefore() does not pass, because MessageCatalogue is mixing up legacy / intl domains

Thank you @xavren.