Skip to content

Fix docblock of two Command methods #46217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix docblock of two Command methods #46217

wants to merge 1 commit into from

Conversation

mostafa-re
Copy link

@mostafa-re mostafa-re commented Apr 29, 2022 •
edited
Loading

Q A
Branch? 6.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46140
License MIT
Doc PR -

@mostafa-re mostafa-re requested a review from chalasr as a code owner April 29, 2022 17:53
@carsonbot carsonbot added this to the 6.1 milestone Apr 29, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@mostafa-re mostafa-re changed the base branch from 6.1 to 6.0 April 29, 2022 18:13
@mostafa-re mostafa-re changed the base branch from 6.0 to 6.1 April 29, 2022 18:14
@mostafa-re
Copy link
Author

Going to make a new pull request targeting branch 6.0.

@mostafa-re mostafa-re closed this Apr 29, 2022
@mostafa-re
Copy link
Author

Reopening as a separated fix for 6.1, because an extra function of Command class has problems in its docblock.

@mostafa-re mostafa-re reopened this Apr 29, 2022
@chalasr
Copy link
Member

chalasr commented Apr 30, 2022

Closing as explained in #46218. Thanks for your understanding

@wouterj wouterj mentioned this pull request Jan 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

@xabbuh xabbuh Awaiting requested review from xabbuh

@lyrixx lyrixx Awaiting requested review from lyrixx

@dunglas dunglas Awaiting requested review from dunglas

@yceruto yceruto Awaiting requested review from yceruto

@wouterj wouterj Awaiting requested review from wouterj

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
6.1
Development

Successfully merging this pull request may close these issues.

[Console] Docblocks in 6.1 are wrongly formatted
4 participants
@mostafa-re @carsonbot @chalasr @nicolas-grekas