[HttpFoundation] Add method getString to ParameterBag
#46245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Alexander M. Turek <me@derrabus.de>
Co-authored-by: Alexander M. Turek <me@derrabus.de>
Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
getString to ParameterBag
|
Hey! I think @W0246645 has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
FabienPapet
reviewed
May 24, 2022
|
|
||
| * Add method `convertString` to `ParameterBag` | ||
| * Rename method `getInt` to `convertInt` in `ParameterBag` | ||
|
|
There was a problem hiding this comment.
but convertInt is not deprecated...?
|
@fabpot , WDT?) |
|
Closing in favor of #44787, which I'm reopening because there are useful comments there that shouldn't be lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added method
getStringtoParameterBagfor use strict type. We really need this method to make it easier to work with strong typing, because thegetmethod returns several data types, and we need a specific one.Reopen old PR #44787, I closed by my mistake...