[Security] Fix division by zero #46309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfcea36 to
8b3d42f
Compare
nicolas-grekas
approved these changes
May 11, 2022
chalasr
approved these changes
May 11, 2022
derrabus
reviewed
May 11, 2022
c54eda3 to
5028662
Compare
|
Good catch, thanks @tvlooy. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given: CSRF token abc.def.ghi was returned
When: I change the value of this token in my browser to abc..ghi
Then: the key becomes '' and the xor that is called in denormalize results in a division by zero and http 500