[Security/Http] Ignore invalid URLs found in failure/success paths #46317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
May 11, 2022
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #43567 |
| License | MIT |
| Doc PR | - |
1a17514 to
389df98
Compare
maxhelias
approved these changes
May 12, 2022
chalasr
approved these changes
May 12, 2022
wouterj
approved these changes
May 12, 2022
wouterj
requested changes
May 12, 2022
| if (\is_string($failureUrl) && str_starts_with($failureUrl, '/')) { | ||
| $options['failure_path'] = $failureUrl; | ||
| } elseif ($this->logger && $failureUrl) { | ||
| $this->logger->debug(sprintf('Ignoring query parameter "%s": not a valid URL.', $options['failure_path_parameter'])); |
There was a problem hiding this comment.
Should we include the value in the log message/context?
There was a problem hiding this comment.
I don't think so: this is user input, might be just garbage. The query parameter name is enough to me.
| } | ||
|
|
||
| if ($this->options['failure_forward']) { | ||
| $options['failure_path'] ?? $options['failure_path'] = $options['login_path']; |
There was a problem hiding this comment.
I must confess that I'm not at all sure if I understand what is going on here. Is this a leftover?
There was a problem hiding this comment.
This is $options['failure_path'] ??= $options['login_path']; written for PHP 7.1+
fabpot
approved these changes
May 13, 2022
|
Thank you @nicolas-grekas. |
Merged
This was referenced May 27, 2022
Merged
Merged
Merged
|
Is there a recommended way to pass through the |
fabpot
added a commit
that referenced
this pull request
Jul 29, 2022
…m Ward) This PR was merged into the 4.4 branch. Discussion ---------- [Security] Allow redirect after login to absolute URLs | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #46533 | License | MIT | Doc PR | Fixes the regression introduced by #46317, and once again allows absolute URLs to be the target of authentication redirection, as specified in the documentation (https://symfony.com/doc/current/security/form_login.html#changing-the-default-page) Commits ------- b9901aa [Security] Allow redirect after login to absolute URLs
nanasess
added a commit
to nanasess/ec-cube
that referenced
this pull request
Aug 8, 2022
- see symfony/symfony#46317 - _target_path 及び _failure_path はURLまたはパスを指定する必要がある - アプリケーション範囲外の URL を指定された場合は homepage へリダイレクトする
nanasess
added a commit
to nanasess/ec-cube
that referenced
this pull request
Aug 8, 2022
- see symfony/symfony#46317 - _target_path 及び _failure_path はURLまたはパスを指定する必要がある - アプリケーション範囲外の URL を指定された場合は homepage へリダイレクトする
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.