[Ldap] Fix LDAP connection options #46325
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! I think @arekzb has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
src/Symfony/Component/Ldap/Adapter/ExtLdap/ConnectionOptions.php
Outdated
Show resolved
Hide resolved
|
Thank you @buffcode. |
Merged
This was referenced May 27, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
LDAP_OPT_X_TLS_CACERTFILEoption in order to specify a CA file which should be used. It is available since the same PHP version as the other options and may just have been forgotten.Furthermore the connection options need to be applied at different stages in order to be effective.
Connection options are tagged to be preconnect-options and are executed before
ldap_connect, all other options continue to be applied betweenldap_connectandldap_bind.Be aware that there is no LDAP documentation about which option is global and thus not requiring a connection and which needs one.
The preconnect options from this PR come from trial-and-error testing and mailing list entries at OpenLDAP.
Maybe also relevant: