[Mime] Throw exception when body in Email attach method is not ok #46367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
402997f to
30f7dc8
Compare
src/Symfony/Component/Mime/Exception/UnexpectedTypeException.php
Outdated
Show resolved
Hide resolved
alamirault
commented
May 17, 2022
| @@ -272,12 +272,16 @@ public function getPriority(): int | |||
| } | |||
|
|
|||
| /** | |||
| * @param resource|string $body | |||
| * @param resource|string|null $body | |||
There was a problem hiding this comment.
Was not documented before but null car be pass
d8a0ee1 to
8561c4e
Compare
nicolas-grekas
approved these changes
May 21, 2022
|
Thank you @alamirault. |
This was referenced May 27, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #45350, throw exception when calling
(new Email())->attach($badBodyType);when type is not supported