[FrameworkBundle] fix wiring of annotations.cached_reader #46427
Conversation
|
(would be even better with a test case if possible) |
| @@ -40,6 +40,10 @@ public function process(ContainerBuilder $container) | |||
| } | |||
| $decoratingDefinitions = []; | |||
|
|
|||
| $tagsToKeep = $container->hasParameter('container.behavior_describing_tags') | |||
| ? $container->getParameter('container.behavior_describing_tags') | |||
| : ['container.do_not_inline', 'container.service_locator', 'container.service_subscriber']; | |||
There was a problem hiding this comment.
should those be merged with the parameter instead ?
There was a problem hiding this comment.
I don't think so: giving full control to the parameter is more flexible to me.
There was a problem hiding this comment.
but does it really make sense to disable core ones ? It would mean that if a project customizes the list, they would not benefit from new additions done in the core like this bugfix until they discover this internal change to the default value.
There was a problem hiding this comment.
This tag is already used in ResolveInstanceofConditionalsPass where is has to contain container.service_locator and other core tags. This code doesn't introduce anything new to me, convention-wise (since this parameter works by convention).
|
Test added. Status: needs review |
Also fixes #26088 (comment)
Instead of trying to hack the compilation of the container to prevent it from inlining
annotations.cached_reader, this PR relies on ancontainer.do_not_inlinetag that just does that, prevent inlining so that removing passes can reliably fetch the corresponding services from the container by id or by tag.