Skip to content

[Routing] Add Requirement::POSITIVE_INT for common ids and pagination #46430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2022
Merged

[Routing] Add Requirement::POSITIVE_INT for common ids and pagination #46430

merged 1 commit into from
May 27, 2022

Conversation

HeahDude
Copy link
Contributor

Q A
Branch? 6.1
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #45528
License MIT
Doc PR ~

I targeted 6.1 because it's not yet released, should I rebase onto 6.2?

ping @fancyweb :)

@carsonbot carsonbot added this to the 6.1 milestone May 21, 2022
derrabus
derrabus approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@derrabus derrabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR improves a feature that is added in 6.1. I think merging it to 6.1 is fine.

chalasr
chalasr approved these changes May 22, 2022
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me on 6.1

@fabpot
Copy link
Member

fabpot commented May 23, 2022

That's unfortunately too late, that will be for 6.2.
There are many other such requirements we could add (and this one is not critical for the feature to be useful).

@fabpot fabpot modified the milestones: 6.1, 6.2 May 23, 2022
@xabbuh xabbuh changed the base branch from 6.1 to 6.2 May 23, 2022 09:09
@HeahDude HeahDude force-pushed the feat/routing-positive-int-requirement branch from a09be64 to bea54e6 Compare May 25, 2022 18:21
@HeahDude
Copy link
Contributor Author

Alright then, rebased and added the proper note in the CHANGELOG.

@nicolas-grekas
Copy link
Member

Thank you @HeahDude.

@nicolas-grekas nicolas-grekas merged commit a10071b into symfony:6.2 May 27, 2022
@nicolas-grekas nicolas-grekas mentioned this pull request May 27, 2022
Closed
@HeahDude HeahDude deleted the feat/routing-positive-int-requirement branch May 27, 2022 15:38
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@derrabus derrabus derrabus approved these changes

@fancyweb fancyweb fancyweb approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature Routing Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
8 participants
@HeahDude @fabpot @nicolas-grekas @OskarStark @derrabus @fancyweb @chalasr @carsonbot