[Security/Http] Throw AccessDeniedException in UserValueResolver when user is required but not authenticated
#46447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AccessDeniedException in UserValueResolver when user is required but not authenticated
a5af2cc to
4801129
Compare
…when user is required but not authenticated When you add `#[CurrentUser] UserInterface $user` to a controller and the user is not authenticated, the following error is produced: ``` Cannot autowire argument $user of "App\Controller::myAction()": it references class "App\User" but no such service exists. ``` This error doesn't help with resolving the problem. The `UserValueResolver` should check and see if the argument is non-optional and immediately stop execution by throwing an `AccessDeniedException`. This can help redirect the user to a login page.
4801129 to
3d638ab
Compare
|
Already done as a feature on 6.1 thanks to #45761. I don't think we want change this on 4.4. |
|
Great then I'll just upgrade to 6.1 soon 🤩 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you add
#[CurrentUser] UserInterface $userto a controller and the user is not authenticated, the following error is produced:This error doesn't help with resolving the problem.
The
UserValueResolvershould check and see if the argument is non-optional and immediately stop execution by throwing anAccessDeniedException. This can help redirect the user to a login page.