[WebProfilerBundle] Fix AJAX requests info are truncated in the WDT #46507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks a good plan @javiereguiluz 👌 Regarding a best solution: in #46495 you mention having the full URL as a title to be able to have it shown by hovering it. |
|
Thank you @tucksaun. |
|
@nicolas-grekas The issue is that this might be a patch solution I am afraid. You can see it here, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At some point (I guess during the WDT redesign, #15160), something changed making the AJAX request table in the WDT just a little bit larger.
This causes the requests to be truncated when the URL is too long:
This PR fixes this by increasing the max-width of the WDT info panel to 525px:
We could reduce the width of the request table to fit in, but 525px seems reasonable enough nowadays and provides more information about the URL.