Skip to content

[Mime] Check that the path is a file in the DataPart::fromPath #46535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

wkania
Copy link
Contributor

@wkania wkania commented May 31, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

The directory can also be readable. Fix to the PR.

Found it while working on another fix related to this method.

@carsonbot carsonbot added this to the 4.4 milestone May 31, 2022
@wkania wkania force-pushed the bugfix/check-that-the-path-is-a-file branch from f367c56 to 315e347 Compare May 31, 2022 21:32
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(with a minor cs comment)

@chalasr
Copy link
Member

chalasr commented Jun 1, 2022

Thank you @wkania.

@chalasr chalasr force-pushed the bugfix/check-that-the-path-is-a-file branch from 4e152ed to a807523 Compare June 1, 2022 19:11
@chalasr chalasr merged commit 03bccf1 into symfony:4.4 Jun 1, 2022
@fabpot fabpot mentioned this pull request Jun 9, 2022
@CoalaJoe
Copy link
Contributor

Is there a reason why this hasn't been released for 4.4 and 5.4 yet? I am running on 5.4 and this is likely causing a bug in one of our projects.

Best regards.

@xabbuh
Copy link
Member

xabbuh commented Jun 23, 2022

We publish patch releases regularly (once a month). Since 4.4.42 has been released 27 days ago I guess there will be a new release soon.

This was referenced Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants