Skip to content

Fix getting class constraints on debug command #46545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

loic425
Copy link
Contributor

@loic425 loic425 commented Jun 1, 2022

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Partially #46544
License MIT
Doc PR

Currently, Symfony debug:validator command does not show constraints that are configured on the class. It only shows constraints of class properties.

So with this fix, we add class constraints on the output tables. - symbol is used on the Propertycolumn to show that the constraint is not linked to a property.

Before
before

After
after

@carsonbot carsonbot added this to the 6.2 milestone Jun 1, 2022
@loic425 loic425 changed the base branch from 6.2 to 5.4 June 1, 2022 16:21
@loic425 loic425 changed the title Fix getting class constraints on debug command [Validator] Fix getting class constraints on debug command Jun 1, 2022
@carsonbot
Copy link

Hey!

I think @alexandre-daubois has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fabpot fabpot modified the milestones: 6.2, 5.4 Jun 2, 2022
@loic425
Copy link
Contributor Author

loic425 commented Jun 7, 2022

@fabpot @nicolas-grekas No one to review this fix? CI is broken but not due to this PR.

@loic425
Copy link
Contributor Author

loic425 commented Jun 7, 2022

I've improved the description of this PR.

@carsonbot carsonbot changed the title [Validator] Fix getting class constraints on debug command Fix getting class constraints on debug command Jun 9, 2022
@nicolas-grekas
Copy link
Member

Thank you @loic425.

@nicolas-grekas nicolas-grekas merged commit 38f4695 into symfony:5.4 Jun 9, 2022
@loic425 loic425 deleted the fix/debug-command branch June 9, 2022 12:36
@fabpot fabpot mentioned this pull request Jun 9, 2022
This was referenced Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants