[Mime] Allow url as a path in the DataPart::fromPath #46548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jun 9, 2022
|
Thank you @wkania. |
Merged
This was referenced Jun 26, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While switching from the Swift Mailer to the Symfony Mailer I encounter a bug
Symfony\Component\Mime\Exception\InvalidArgumentException.Steps to reproduce:
An exception has been thrown during the rendering of a template.DataPart can't be created from url, even if
fopencan open url.Apparently, before Symfony 4.4.11 this worked with URLs. At least in the context of email with attachments.
PHP doesn't support rewind on non-local streams, so calling multiple times method
getBodyfromTextPartwould return an empty string. So in another context, it worked partially.Additional notes: