Skip to content

[Serializer] Fix ignore attribute in Xml files #46577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2022
Merged

[Serializer] Fix ignore attribute in Xml files #46577

merged 1 commit into from
Jun 5, 2022

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Jun 3, 2022 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46463
License MIT

Before this PR foo was ignored. Now it is not.

<class name="Symfony\Component\Serializer\Tests\Fixtures\Annotations\IgnoreDummy">
    <attribute name="foo" ignore="false" />
</class>

Instead of cast we now use XmlUtils::phpize like others XmlLoaders.

@alamirault alamirault requested a review from dunglas as a code owner June 3, 2022 18:18
@carsonbot carsonbot added this to the 5.4 milestone Jun 3, 2022
@carsonbot
Copy link

Hey!

I think @localheinz has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@fabpot
Copy link
Member

fabpot commented Jun 5, 2022

Thank you @alamirault.

@fabpot fabpot merged commit 91f79fa into symfony:5.4 Jun 5, 2022
@fabpot fabpot mentioned this pull request Jun 9, 2022
Merged
This was referenced Jun 26, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@alamirault @carsonbot @fabpot