[Console] Fix deprecation when description is null #46608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
approved these changes
Jun 7, 2022
| @@ -56,6 +56,7 @@ public function process(ContainerBuilder $container) | |||
| foreach ($commandServices as $id => $tags) { | |||
| $definition = $container->getDefinition($id); | |||
| $definition->addTag($this->noPreloadTag); | |||
| /** @var class-string<Command> $class */ | |||
There was a problem hiding this comment.
This change looks unrelated and should be reverted.
str_replace(): Passing null to parameter symfony#3 ($subject) of type array|string is deprecated
ae00115 to
7a08b52
Compare
fabpot
approved these changes
Jun 7, 2022
|
Good catch, thanks @HypeMC. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
str_replace(): Passing null to parameter #3 ($subject) of type array|string is deprecatedwhengetDefaultDescription()returnsnull, caused by #46574.