Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

• Always add tests
• Keep backward compatibility (see https://symfony.com/bc).
• Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
• Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

Hi there! I'm very happy to see that you followed the contribution guide and did such a complete contribution. However, this change has been rejected before already and I don't think the situation has changed now: #39634, #40391

You don't need to mock the RateLimiterFactory in order to write unit tests. In fact, mocking a factory class often results in increased maintenance costs with little gain. You can see an example on how to use the factory in a unit test in Symfony's code:

More information about this methodology of writing tests can be found in e.g. this blog post: https://blog.frankdejonge.nl/testing-without-mocking-frameworks/

If you have any other comments or questions, feel free to leave a comment :)

This uses InMemoryStorage and no limiter instead of mocking.

Ah perfect, I hadn't realised this! I probably should have searched a bit more thoroughly for those issues, I'll close this PR.