Skip to content

[Ldap] Fixing missing 'user_identifier' forward compatibility in CheckLdapCredentialsListener #46681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 0 commits into from
Closed

[Ldap] Fixing missing 'user_identifier' forward compatibility in CheckLdapCredentialsListener #46681

wants to merge 0 commits into from

Conversation

ktherage
Copy link
Contributor

@ktherage ktherage commented Jun 15, 2022 •
edited
Loading

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This PR aims to fix a missing forward compatibility when authenticating with LDAP and using the following configuration :

security:
// ...
    firewalls:
    // ...
        main:
            form_login_ldap:
                // ...
                query_string: '(whatever={user_identifier})'

instead of :

security:
// ...
    firewalls:
    // ...
        main:
            form_login_ldap:
                // ...
                query_string: '(whatever={username})'

related to : #40403

@ktherage ktherage requested review from wouterj and chalasr as code owners June 15, 2022 12:42
@carsonbot carsonbot added this to the 6.2 milestone Jun 15, 2022
@carsonbot carsonbot changed the title [LDAP] Fixing missing 'user_identifier' forward compatibility in CheckLdapCredentialsListener [Ldap] Fixing missing 'user_identifier' forward compatibility in CheckLdapCredentialsListener Jun 15, 2022
@ktherage ktherage changed the base branch from 6.2 to 5.4 June 15, 2022 12:46
@ktherage ktherage closed this Jun 15, 2022
@ktherage ktherage force-pushed the ldap_forward_compat branch from 8bce212 to 9a65138 Compare June 15, 2022 12:51
@ktherage
Copy link
Contributor Author

Sorry I did messy things on that PR see #46683 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj Awaiting requested review from wouterj

@chalasr chalasr Awaiting requested review from chalasr

@lyrixx lyrixx Awaiting requested review from lyrixx

@yceruto yceruto Awaiting requested review from yceruto

@dunglas dunglas Awaiting requested review from dunglas

@OskarStark OskarStark Awaiting requested review from OskarStark

@jderusse jderusse Awaiting requested review from jderusse

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees
No one assigned
Labels
Bug Ldap Status: Needs Review
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
2 participants
@ktherage @carsonbot