Hey!

I think @sbelyshkin has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@jrjohnson I don't know all the details of your case but from my perspective PSR-6 methods is the best choice for your scenario. RedisAdapter::getItems() can fetch all the objects with a single MGET, and then commit() will send all saveDeffered() SET operations in a pipeline. In this way you can reduce the round trip time.

$hitsAndMisses = $this->cache->getItems($ids); // produces MGET id1, id2,... for Redis

$hits = $misses = [];
foreach($hitsAndMisses as $cacheItem) {
    if ($cacheItem->isHit()) {
       $hits[$cacheItem->getKey()] = $cacheItem->get();
    } else {
       $misses[$cacheItem->getKey()] = $cacheItem;
    }
}

$hydrated = $this->hydrate(array_keys($misses)); //very expensive to do individually

foreach($hydrated as $obj) {
    $this->cache->saveDeffered($misses[$obj->id]->set($obj));
}

$this->cache->commit(); // sends all SET commands in a pipeline and reads a single response

return array_values([...$hits, ...$hydrated]);

get() is obviously designed for dealing with single items.
At the same time, I agree that the described behavior of ArrayAdapter looks unexpected, compared to the others.

Thank you @jrjohnson.

Happy to help!

Thanks @sbelyshkin, for the info. I need to take advantage of tags and I don't think I can do that with the PSR6 cache. I'm going to refactor our reads to use those methods though and save some significant back and forth!