[PhpUnitBridge] Exclude from baseline generation deprecations triggered in legacy test #46711
Conversation
mondrake
commented
Jun 18, 2022
| Q | A |
|---|---|
| Branch? | 6.1 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #46710 |
| License | MIT |
|
Thank you @mondrake. |
|
Thanks @nicolas-grekas! However I think we need to adjust some tests that are now failing - how do you usually do that? Revert and fix, new PR, or? Sorry I come from Drupal world, not yet accustomed to Symfony's etiquette. |
|
Tests will be fixed in #46719 . |
|
To answer your questions about the "normal process" of failing tests: Normally, we don't merge PRs that cause test failures, but sometimes we missed that a PR introduced new failing tests (I think that's what happened here). Due to third party changes or other changes when upmerging older versions into newer branches, our branches often have a few failing tests. If you feel like it, we always welcome people submitting a PR to fix failing tests :) Otherwise, a core team member takes care of it (as the branches have to be green before releasing a new version at the end of the month). |
|
Thanks @wouterj - I see fixes are already under way, so I'll just pause here. |