Skip to content

Initially set user null. #46766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 25, 2022
Merged

Initially set user null. #46766

merged 1 commit into from
Jun 25, 2022

Conversation

mogilvie
Copy link
Contributor

@mogilvie mogilvie commented Jun 24, 2022

getUser is ?UserInterface return, but throws unset user exception.

Typed property Symfony\Component\Security\Core\Exception\AccountStatusException::$user must not be accessed before initialization

Q A
Branch? 6.1 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix null initialization error on getUser
License MIT
Doc PR symfony/symfony-docs#...

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@xabbuh xabbuh modified the milestones: 6.2, 6.1 Jun 24, 2022
getUser is ?UserInterface return, but throws unset user exception.

Typed property Symfony\Component\Security\Core\Exception\AccountStatusException::$user must not be accessed before initialization
@fabpot fabpot changed the base branch from 6.2 to 6.1 June 25, 2022 06:59
@fabpot
Copy link
Member

fabpot commented Jun 25, 2022

Thank you @mogilvie.

@fabpot fabpot merged commit d790f00 into symfony:6.1 Jun 25, 2022
@fabpot fabpot mentioned this pull request Jun 26, 2022
@mogilvie mogilvie deleted the patch-1 branch October 6, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants