[Bridge] Corrects bug in test listener trait #46792
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
2959cb4 to
ebf388a
Compare
ostrolucky
approved these changes
Jul 3, 2022
|
I've added a test for this based on the initial report of the issue. A bunch of the tests are failing but the failures seem to be unrelated to this change. |
fabpot
approved these changes
Jul 20, 2022
fabpot
approved these changes
Jul 20, 2022
16af875 to
d7d4bd7
Compare
|
Thank you @magikid. |
This was referenced Jul 29, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you enable the
SymfonyTestsListenerTrait, use theExpectDeprecationTrait, and call$this->expectNotToPerformAssertions(), an error was returned in yourtest saying it was risky as it did not perform any assertions even
though it was expected not to.
This bug turned out to be caused by not checking if the
doesNotPerformAssertionsflag had been set.Issue: #41444
This fixes a bug that could occur when using this listener along with the
ExpectDeprecationTraittrait and theTestCase::expectNotToPerformAssertions()method. When that method is called, the user is saying that no assertions will happen but the listener didn't care and saw no assertions and none skipped so threw the 'No assertions' warning message. This updates the listener to check the value ofTestCase::doesNotPerformAssertionswhen deciding to warn about no assertions or not.