[ExpressionLanguage] Revert readonly flag on ConstantNode::$isNullSafe #46840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might be a bug in VarExporter. Can you please share a reproducer? |
|
Please also open a separate issue about the need to handle readonly properties in VarExporter |
|
All deps are on latest tag 6.1.x. Filtres.php : class Filtres
{
/** @var string|null */
public $recherche;
/** @var Statut|null */
public $statut;
/** @var DateTimeImmutable|null */
public $dateDeDebut;
/** @var DateTimeImmutable|null */
public $dateDeFin;
}FiltresType.php : class FiltresType extends AbstractType
{
public function buildForm(FormBuilderInterface $builder, array $options): void
{
$builder->add('recherche', TextType::class, [
'required' => false,
]);
if ((bool) $options['statut']) {
$builder
->add('statut', ChoiceType::class, [
'required' => false,
'choices' => ['oui', 'non'],
'choice_label' => 'label',
'choice_value' => 'value',
])
->add('dateDeDebut', DateType::class, [
'input' => 'datetime_immutable',
'widget' => 'single_text',
'required' => false,
])
->add('dateDeFin', DateType::class, [
'input' => 'datetime_immutable',
'widget' => 'single_text',
'required' => false,
])
;
}
$builder->add('submit', SubmitType::class);
}
public function configureOptions(OptionsResolver $resolver): void
{
$resolver
->setRequired('statut')
->setAllowedTypes('statut', 'bool')
->setRequired('statut_brouillon')
->setAllowedTypes('statut', 'bool')
;
}
}Filtres.yaml : App\x\Filtres:
properties:
dateDeDebut:
- Type: DateTimeImmutable
dateDeFin:
- Type: DateTimeImmutable
- Expression:
expression: this.dateDeDebut === null || value === null || value >= this.dateDeDebutFiltresTypeTest.php : class FiltresTypeTest extends FormTestCase
{
/**
* @dataProvider provideValidDataCases
*
* @param array<string, array<string>> $submittedData
*/
public function test_it_hydrates_the_model_with_valid_values(
FiltresCras $model,
array $submittedData,
FiltresCras $expected,
): void
{
$form = self::getContainer()->get('form.factory')->create(FiltresType::class, $model, [
'statut' => true,
'statut_brouillon' => true,
]);
$form->submit($submittedData);
self::assertTrue($form->isSynchronized());
self::assertTrue($form->isValid());
self::assertEquals($expected, $model);
}
public function provideValidDataCases(): iterable
{
$model = new Filtres();
$expected = clone $model;
yield [
$model,
[],
$expected,
];
}
}I hope it's enough to have a look, thanks. |
|
Closing in favor of #46841 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #45795, the new property
ConstantNode::$isNullSafeisreadonlybut when Hydrator of VarExporter component tries to hydrateSymfony\Component\ExpressionLanguage\Compiler\ConstantNodehere, we get an "Error: Cannot initialize readonly property Symfony\Component\ExpressionLanguage\Node\ConstantNode::$isNullSafe from scope Symfony\Component\VarExporter\Internal\Hydrator".My stacktrace :
Friendly ping @mytuny