Skip to content

Console/SymfonyStyle: Add Multiselect to choice() #46896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

julien-boudry
Copy link
Contributor

Q A
Branch? 6.2 for features
Bug fix? no
New feature? yes
Deprecations? no
License MIT

SymfonyStyle did not allow multiselect choice in any way

@julien-boudry julien-boudry requested a review from chalasr as a code owner July 10, 2022 16:11
@carsonbot carsonbot added this to the 6.1 milestone Jul 10, 2022
@julien-boudry julien-boudry changed the base branch from 6.1 to 6.2 July 10, 2022 16:14
@fabpot fabpot modified the milestones: 6.1, 6.2 Jul 10, 2022
Copy link
Member

@fabpot fabpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you maybe add a test to cover this new option?

@julien-boudry
Copy link
Contributor Author

I didn't find any test for the original choice method from SymfonyStyle

@fabpot
Copy link
Member

fabpot commented Jul 11, 2022

Thank you @julien-boudry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants