Skip to content

[BrowserKit] fix sending request to paths containing multiple slashes #46905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 15, 2022
Merged

[BrowserKit] fix sending request to paths containing multiple slashes #46905

merged 1 commit into from
Jul 15, 2022

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 11, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46900
License MIT
Doc PR

@xabbuh xabbuh added this to the 4.4 milestone Jul 11, 2022
@xabbuh xabbuh mentioned this pull request Jul 11, 2022
Closed
@nicolas-grekas
Copy link
Member

There are other similar checks in the codebase, let's update them all?
grep "'//'" src/ -r

@xabbuh xabbuh changed the title [BrowserKit] fix sending request to double slash path [BrowserKit] fix sending request to paths containing multiple slashes Jul 13, 2022
@fabpot
Copy link
Member

fabpot commented Jul 15, 2022

Thank you @xabbuh.

@fabpot fabpot merged commit 2184f32 into symfony:4.4 Jul 15, 2022
@xabbuh xabbuh deleted the issue-46900 branch July 15, 2022 12:42
This was referenced Jul 29, 2022
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
BrowserKit Bug Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@xabbuh @nicolas-grekas @fabpot @chalasr @carsonbot