Skip to content

[HttpKernel] Declare properties used by CacheAttributeListenerTest explicitly #46945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2022
Merged

[HttpKernel] Declare properties used by CacheAttributeListenerTest explicitly #46945

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Symfony/Component/HttpKernel/Tests/EventListener/CacheAttributeListenerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,12 @@

class CacheAttributeListenerTest extends TestCase
{
private CacheAttributeListener $listener;
private Response $response;
private Cache $cache;
private Request $request;
private ResponseEvent $event;

protected function setUp(): void
{
$this->listener = new CacheAttributeListener();
Expand Down Expand Up @@ -294,12 +300,12 @@ public function testAttribute()
$this->assertSame(CacheAttributeController::CLASS_SMAXAGE, $response->getMaxAge());
}

private function createRequest(Cache $cache = null)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: We always pass the argument and we never pass null.

private function createRequest(Cache $cache): Request
{
return new Request([], [], ['_cache' => [$cache]]);
}

private function createEventMock(Request $request, Response $response)
private function createEventMock(Request $request, Response $response): ResponseEvent
{
return new ResponseEvent($this->getKernel(), $request, HttpKernelInterface::MAIN_REQUEST, $response);
}
Expand Down