Skip to content

[HttpFoundation] Fix \Stringable support in InputBag::get() #46957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

chalasr
Copy link
Member

@chalasr chalasr commented Jul 16, 2022

Q A
Branch? 6.0
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Spotted in #46936 (comment), thanks @fritzmg.

@chalasr chalasr force-pushed the inputbag-get-stringable branch from 3a80769 to 6dfe92e Compare July 16, 2022 20:54
@chalasr chalasr changed the base branch from 6.2 to 6.0 July 16, 2022 20:54
@chalasr chalasr modified the milestones: 6.2, 6.0 Jul 16, 2022
@chalasr
Copy link
Member Author

chalasr commented Jul 22, 2022

@fabpot Please close if we don't want to fix that inconsistency :)

@fabpot
Copy link
Member

fabpot commented Jul 22, 2022

I still don't get the use case to be very honest (get and set).

@chalasr
Copy link
Member Author

chalasr commented Jul 22, 2022

That was meant to be temporary à priori, but we can't make it stop as a bugfix. So I'd say this can be merged, and we can deprecate the \Stringable support for both get and set on 6.2 (I can do the PR later in the weekend).

@fabpot
Copy link
Member

fabpot commented Jul 22, 2022

If we deprecate it in 6.2, let's not merge this PR.

@chalasr chalasr closed this Jul 22, 2022
@fritzmg
Copy link
Contributor

fritzmg commented Jul 22, 2022

If we deprecate it in 6.2, let's not merge this PR.

But then set and get stay inconsistent in 6.x? I do not understand why you do not want to fix this.

@fabpot
Copy link
Member

fabpot commented Jul 22, 2022

Because we don't want people to use it as we will deprecate the feature in 6.2.

@chalasr
Copy link
Member Author

chalasr commented Jul 22, 2022

The thing is that it works on 5.4, so anyone relying on this will have their code breaks when upgrading to 6.x.
Probably not a big deal so let's reconsider if someone complains about it

@fabpot
Copy link
Member

fabpot commented Jul 22, 2022

Oh, I didn't remember that it used to work on 5.4. Let's merge then, but let's not forget the 6.2 PR to deprecate this.

@fabpot fabpot reopened this Jul 22, 2022
@fabpot
Copy link
Member

fabpot commented Jul 22, 2022

Thank you @chalasr.

@fabpot fabpot merged commit 36aabb2 into symfony:6.0 Jul 22, 2022
@chalasr chalasr deleted the inputbag-get-stringable branch July 22, 2022 16:43
This was referenced Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants