-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[HttpFoundation] Fix \Stringable
support in InputBag::get()
#46957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
83130b6
to
3a80769
Compare
3a80769
to
6dfe92e
Compare
@fabpot Please close if we don't want to fix that inconsistency :) |
I still don't get the use case to be very honest (get and set). |
That was meant to be temporary à priori, but we can't make it stop as a bugfix. So I'd say this can be merged, and we can deprecate the \Stringable support for both |
If we deprecate it in 6.2, let's not merge this PR. |
But then |
Because we don't want people to use it as we will deprecate the feature in 6.2. |
The thing is that it works on 5.4, so anyone relying on this will have their code breaks when upgrading to 6.x. |
Oh, I didn't remember that it used to work on 5.4. Let's merge then, but let's not forget the 6.2 PR to deprecate this. |
Thank you @chalasr. |
Spotted in #46936 (comment), thanks @fritzmg.