Skip to content

[HttpFoundation] Rename Request::getContentType() to getContentFormat() #46987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HttpFoundation] Rename Request::getContentType() to getContentFormat() #46987

wants to merge 1 commit into from

Conversation

ihmels
Copy link
Contributor

@ihmels ihmels commented Jul 19, 2022

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? yes
Tickets Fix #39750
License MIT
Doc PR n/a

This PR renames the Request::getContentType() to getContentFormat() for less confusion.

@ihmels ihmels requested review from wouterj and chalasr as code owners July 19, 2022 20:45
@carsonbot carsonbot added this to the 6.2 milestone Jul 19, 2022
@ihmels ihmels changed the title Rename Request::getContentType() to getContentFormat() [HttpFoundation] Rename Request::getContentType() to getContentFormat() Jul 19, 2022
@ihmels
Copy link
Contributor Author

ihmels commented Jul 19, 2022

Sorry, I overlooked the PR #45034. Closing this.

@ihmels ihmels closed this Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj Awaiting requested review from wouterj wouterj is a code owner

@chalasr chalasr Awaiting requested review from chalasr chalasr is a code owner

Assignees
No one assigned
Labels
Deprecation Status: Needs Review
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

Request::getContentType() method name is confusing
2 participants
@ihmels @carsonbot