Skip to content

[DependencyInjection] Fixed unescaping of class arguments #4707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[DependencyInjection] Fixed unescaping of class arguments #4707

wants to merge 1 commit into from

Conversation

avorobiev
Copy link

@avorobiev avorobiev mentioned this pull request Jul 2, 2012
Closed
vicb
vicb reviewed Jul 2, 2012
View reviewed changes
src/Symfony/Component/DependencyInjection/CHANGELOG.md
@@ -10,3 +10,6 @@ CHANGELOG
* added Definition::clearTag()
* component exceptions that inherit base SPL classes are now used exclusively
(this includes dumped containers)
* fixed unescaping of class arguments, method ParameterBag::unescapeValue() was made
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you prepend "[BC BREAK]" please ?

@vicb
Copy link
Contributor

vicb commented Jul 2, 2012

@avorobiev could you please take care of the 2 small updates and it will be mergeable. thanks.

@avorobiev
Copy link
Author

@vicb And it's done :-) #4708

@avorobiev avorobiev closed this Jul 2, 2012
@vicb
Copy link
Contributor

vicb commented Jul 2, 2012

Thanks. Just FYI you don't have to create a new PR each time, you can force push to the same branch in order to update the PR.

@avorobiev
Copy link
Author

I don't know it. Thanks. Next time i'll do force push.

@vicb
Copy link
Contributor

vicb commented Jul 2, 2012

If you want to test it you can squash your 2 commits (in 4708) and force push (to have only a single commit)

@avorobiev
Copy link
Author

Yes, @vicb, thank you for tips.
I knew about force commit and squash in Git. But I didn't know that if I rebase branch + squash 2 commits + make force push to the same branch then GitHub will link it with the same issue and everythings will be ok. I was afraid that it broke something in github interfaces.
Now I understand that I could do it. So, next time I'll do it better :-).

craigmarvelley pushed a commit to craigmarvelley/symfony that referenced this pull request Nov 26, 2013
@fabpot
merged branch avorobiev/fix1 (PR symfony#4708)
b26cd4c 
Commits
-------

036c15e [DependencyInjection] Unescape class arguments part 2
19bdae1 [DependencyInjection] Fixed unescaping of class arguments

Discussion
----------

[DependencyInjection] Fixed unescaping of class arguments

symfony#4707
@GuilhemN GuilhemN mentioned this pull request Jan 13, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@avorobiev @vicb