Skip to content

[HttpKernel] Fix non-scalar check in surrogate fragment renderer #47073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2022
Merged

[HttpKernel] Fix non-scalar check in surrogate fragment renderer #47073

merged 1 commit into from
Jul 29, 2022

Conversation

aschempp
Copy link
Contributor

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #46152
License MIT
Doc PR -

@carsonbot carsonbot added this to the 4.4 milestone Jul 27, 2022
@aschempp aschempp mentioned this pull request Jul 27, 2022
Closed
@fabpot
Copy link
Member

fabpot commented Jul 27, 2022

@aschempp Can you have a look at the tests, they seem to be broken by this change.

@carsonbot carsonbot changed the title Fix non-scalar check in surrogate fragment renderer [HttpKernel] Fix non-scalar check in surrogate fragment renderer Jul 29, 2022
@nicolas-grekas nicolas-grekas force-pushed the bugfix/fragment-scalar-check branch from 65a2593 to 6b85cfd Compare July 29, 2022 06:51
@nicolas-grekas
Copy link
Member

Thank you @aschempp.

@nicolas-grekas nicolas-grekas merged commit 03bdaed into symfony:4.4 Jul 29, 2022
This was referenced Jul 29, 2022
Merged
Merged
Merged
Merged
@aschempp aschempp deleted the bugfix/fragment-scalar-check branch August 3, 2022 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

Assignees
No one assigned
Labels
Bug HttpKernel Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@aschempp @fabpot @nicolas-grekas @carsonbot