Workaround disabled "var_dump" #47086
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jul 27, 2022
| Q | A |
|---|---|
| Branch? | 4.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #46881 |
| License | MIT |
| Doc PR | - |
chalasr
approved these changes
Jul 27, 2022
Comment on lines
-358
to
360
| $handler = set_error_handler('var_dump'); | ||
| $handler = set_error_handler('is_int'); | ||
| $handler = \is_array($handler) ? $handler[0] : null; | ||
| restore_error_handler(); |
There was a problem hiding this comment.
If ever is_int was called, it would throw an ArgumentCountError, so a few questions:
- Is that actually a good thing?
- Are there reasons for not passing
nullhere? or e.g.function () {}? - Would it be safer to move up the
restore_{error|exception}_handler();immediately after theset_{error|exception}_handlercall, with no operation in-between? - Should add get_error_handler() and get_exception_handler() php/php-src#969 be revived?
There was a problem hiding this comment.
Should php/php-src#969 be revived?
Maybe. For your other questions, they're mostly theoretical at the moment so I wouldn't care much :)
This was referenced Jul 29, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.