Skip to content

[Mailer] re-add test #47106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2022
Merged

[Mailer] re-add test #47106

merged 1 commit into from
Jul 29, 2022

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Jul 29, 2022

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

This test was initially added in #46211 but failed because of the changes from #46963 that were merged in the meantime. The test was then removed in e54dd38. This is a fixed version that is passing again.

@xabbuh
Copy link
Member Author

xabbuh commented Jul 29, 2022

This is the actual diff:

--- a/src/Symfony/Component/Mailer/Bridge/Infobip/Tests/Transport/InfobipApiTransportTest.php
+++ b/src/Symfony/Component/Mailer/Bridge/Infobip/Tests/Transport/InfobipApiTransportTest.php
@@ -332,11 +332,23 @@ class InfobipApiTransportTest extends TestCase
             %a
             Content-Type: multipart/mixed; boundary=%s
 
+            --%s
+            Content-Type: multipart/related; boundary=%s
+
             --%s
             Content-Type: text/plain; charset=utf-8
             Content-Transfer-Encoding: quoted-printable
 
             foobar
+            --%s
+            Content-ID: %s
+            Content-Type: text/plain; name=inline.txt
+            Content-Transfer-Encoding: base64
+            Content-Disposition: inline; name=inline.txt; filename=inline.txt
+
+            c29tZSBpbmxpbmUgYXR0YWNobWVudA==
+            --%s--
+
             --%s
             Content-Type: text/plain; name=attachment.txt
             Content-Transfer-Encoding: base64
@@ -344,12 +356,6 @@ class InfobipApiTransportTest extends TestCase
              filename=attachment.txt
 
             c29tZSBhdHRhY2htZW50
-            --%s
-            Content-Type: text/plain; name=inline.txt
-            Content-Transfer-Encoding: base64
-            Content-Disposition: inline; name=inline.txt; filename=inline.txt
-
-            c29tZSBpbmxpbmUgYXR0YWNobWVudA==
             --%s--
             TXT,
             $sentMessage->toString()

@fabpot
Copy link
Member

fabpot commented Jul 29, 2022

Thank you @xabbuh.

@fabpot fabpot merged commit 4811813 into symfony:6.2 Jul 29, 2022
@xabbuh xabbuh deleted the pr-46211 branch July 29, 2022 10:28
@fabpot fabpot mentioned this pull request Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants