[HttpFoundation] Fix invalid ID not regenerated with native PHP file sessions #47130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrabus
reviewed
Jul 31, 2022
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/StrictSessionHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/StrictSessionHandler.php
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Session/Storage/Handler/StrictSessionHandler.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Session/Storage/Proxy/SessionHandlerProxy.php
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Proxy/SessionHandlerProxyTest.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/HttpFoundation/Tests/Session/Storage/Proxy/SessionHandlerProxyTest.php
Outdated
Show resolved
Hide resolved
Rezyan
commented
Aug 1, 2022
There was a problem hiding this comment.
Maybe we should use a more intuitive name for the method? Like isInternalWrapper, wrapsInternalHandler, hasInternalHandler. What do you think @nicolas-grekas? In my opinion, this makes the method more understandable.
/**
* Returns true if this handler wraps an internal PHP session save handler using \SessionHandler.
*
* @internal
*/
- public function isWrapper(): bool
+ public function isInternalWrapper(): bool
{
return $this->handler instanceof \SessionHandler;
} /**
* Returns true if this handler wraps an internal PHP session save handler using \SessionHandler.
*
* @internal
*/
- public function isWrapper(): bool
+ public function wrapsInternalHandler(): bool
{
return $this->handler instanceof \SessionHandler;
} /**
* Returns true if this handler wraps an internal PHP session save handler using \SessionHandler.
*
* @internal
*/
- public function isWrapper(): bool
+ public function hasInternalHandler(): bool
{
return $this->handler instanceof \SessionHandler;
}
nicolas-grekas
approved these changes
Aug 1, 2022
|
Thank you @brokensourcecode. |
This was referenced Aug 26, 2022
Merged
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside the
SessionHandlerProxyclass, the code defines$this->saveHandlerNameto\ini_get('session.save_handler')when$handleris an instance of\SessionHandler.symfony/src/Symfony/Component/HttpFoundation/Session/Storage/Proxy/SessionHandlerProxy.php
Lines 24 to 25 in 818d4dd
But inside the
NativeSessionStorageclass, the code create an instance ofStrictSessionHandlerthat doesn't inherit from\SessionHandlerand is passed to theSessionHandlerProxyconstructor.symfony/src/Symfony/Component/HttpFoundation/Session/Storage/NativeSessionStorage.php
Lines 422 to 424 in 818d4dd
Therefore, we could create a
isWrapper()method inside theStrictSessionHandlerclass to check if the wrapped handler is an internal PHP session handler (\SessionHandler), just likeAbstractProxy::isWrapper().That's the only solution I have in mind right now.