-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[FrameworkBundle] fix writes to static $kernel property #47195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
xabbuh
commented
Aug 5, 2022
Q | A |
---|---|
Branch? | 4.4 |
Bug fix? | yes |
New feature? | no |
Deprecations? | no |
Tickets | Fix #47186 |
License | MIT |
Doc PR |
I tested this patch against my 4.4 app, and it fixes the issue mentioned in #47186 |
Pleas note that the problem also exists in newer Symfony versions, e.g.: symfony/src/Symfony/Bundle/FrameworkBundle/Test/KernelTestCase.php Lines 74 to 77 in d404246
Should I open a separate ticket for forward ports? |
As I do not understood how this change here is related to forward ports it seems indeed to be better to open a new issue that describes what you have in mind. :) |
Sorry, I'm not sure is forward ports is actually a word, I meant it as the opposite of backports (because this is how you do in Symfony, right? You merge to the lowest branch and then you port forwards from there). What I meant to say was the confusion between |
Oh, I completely misunderstood your previous comment then. :) I was thinking in terms of forwarded ports when using an HTTP proxy. 😄 I have now merged everything up into the |
Awesome, thanks! |