Skip to content

[FrameworkBundle] fix writes to static $kernel property #47195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Aug 5, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #47186
License MIT
Doc PR

@flack
Copy link
Contributor

flack commented Aug 5, 2022

I tested this patch against my 4.4 app, and it fixes the issue mentioned in #47186

@xabbuh xabbuh merged commit 675756f into symfony:4.4 Aug 5, 2022
@xabbuh xabbuh deleted the issue-47186 branch August 5, 2022 09:29
@flack
Copy link
Contributor

flack commented Aug 8, 2022

Pleas note that the problem also exists in newer Symfony versions, e.g.:

self::$kernel = $kernel;
static::$booted = true;
return static::$kernel;

Should I open a separate ticket for forward ports?

@xabbuh
Copy link
Member Author

xabbuh commented Aug 8, 2022

As I do not understood how this change here is related to forward ports it seems indeed to be better to open a new issue that describes what you have in mind. :)

@flack
Copy link
Contributor

flack commented Aug 8, 2022

Sorry, I'm not sure is forward ports is actually a word, I meant it as the opposite of backports (because this is how you do in Symfony, right? You merge to the lowest branch and then you port forwards from there).

What I meant to say was the confusion between self::$kernel and static::$kernel also exists in newer branches, including 6.2. So the reproduction code in #47186 (or something similar) would also produce an error on these newer branches

@xabbuh
Copy link
Member Author

xabbuh commented Aug 8, 2022

Oh, I completely misunderstood your previous comment then. :) I was thinking in terms of forwarded ports when using an HTTP proxy. 😄 I have now merged everything up into the 6.2 branch.

@flack
Copy link
Contributor

flack commented Aug 8, 2022

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants