Allow extending #[When] attribute
#47196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
I like that change. Please add tests though. |
This allows people to extend the When attribute with something like this:
```php
use Attribute;
use Symfony\Component\DependencyInjection\Attribute\When;
#[Attribute(Attribute::TARGET_CLASS | Attribute::TARGET_METHOD | Attribute::TARGET_FUNCTION | Attribute::IS_REPEATABLE)]
final class Exclude extends When
{
public function __construct()
{
parent::__construct('never');
}
}
```
Then they can use `#[Exclude]` instead of `#[When(env: 'never')]`.
References:
- symfony#46643
- symfony#46655
|
@derrabus Done! |
derrabus
approved these changes
Aug 5, 2022
nicolas-grekas
approved these changes
Aug 5, 2022
fabpot
approved these changes
Aug 5, 2022
|
Thank you @ruudk. |
Merged
ruudk
added a commit
to ruudk/symfony
that referenced
this pull request
Jun 18, 2025
This allows people to extend the `#[AsAlias]` attribute with something like this:
```php
namespace App\Symfony;
use Symfony\Component\DependencyInjection\Attribute\AsAlias;
final class AsProductionAlias extends AsAlias
{
/**
* @param string|null $id The id of the alias
* @param bool $public Whether to declare the alias public
*/
public function __construct(
public ?string $id = null,
public bool $public = false,
) {
parent::__construct($id, $public, ['prod']);
}
}
```
This is similar to a previous change I did for the `#[When]` attribute, that was accepted:
- symfony#47196
nicolas-grekas
added a commit
that referenced
this pull request
Jun 18, 2025
…ribute (ruudk)
This PR was squashed before being merged into the 7.4 branch.
Discussion
----------
[DependencyInjection] Allow extending `#[AsAlias]` attribute
| Q | A
| ------------- | ---
| Branch? | 7.4
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Issues |
| License | MIT
This allows people to extend the `#[AsAlias]` attribute with something like this:
```php
namespace App\Symfony;
use Symfony\Component\DependencyInjection\Attribute\AsAlias;
final class AsProductionAlias extends AsAlias
{
/**
* `@param` string|null $id The id of the alias
* `@param` bool $public Whether to declare the alias public
*/
public function __construct(
public ?string $id = null,
public bool $public = false,
) {
parent::__construct($id, $public, ['prod']);
}
}
```
This is similar to a previous change I did for the `#[When]` attribute, that was accepted:
- #47196
Commits
-------
90fd3ff [DependencyInjection] Allow extending `#[AsAlias]` attribute
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to extend the
#[When]attribute with something like this:Then they can use
#[Exclude]instead of#[When(env: 'never')].Or they can create
#[ProductionOnly]instead of#[When(env: 'prod')].I hoped that #46655 would be merged but it turns out that is not going to happen.
References:
#[Exclude]in order to not register as a service #46655