[Serializer] Fix get accessor regex in AnnotationLoader #47255
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
Aug 11, 2022
src/Symfony/Component/Serializer/Mapping/Loader/AnnotationLoader.php
Outdated
Show resolved
Hide resolved
nicolas-grekas
approved these changes
Aug 11, 2022
fabpot
approved these changes
Aug 12, 2022
|
Thank you @jsor. |
fabpot
added a commit
that referenced
this pull request
Aug 12, 2022
…sor) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [Serializer] Fix get accessor regex in AnnotationLoader The pipe in the regex makes it match *all* methods. | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | n/a | License | MIT | Doc PR | n/a This fixes a bug introduced in #46958. It was also discovered in the PR but after it got merged. See #46958 (comment). Commits ------- 1132171 [Serializer] Fix get accessor regex in AnnotationLoader
1 task
This was referenced Aug 26, 2022
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pipe in the regex makes it match all methods.
This fixes a bug introduced in #46958. It was also discovered in the PR but after it got merged. See #46958 (comment).