Skip to content

[Intl] Update EmojiTransliterator to translate emoji to github and slack short code #47263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2022
Merged

[Intl] Update EmojiTransliterator to translate emoji to github and slack short code #47263

merged 1 commit into from
Aug 17, 2022

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Aug 12, 2022

Q A
Branch? 6.2
Bug fix? yes
New feature? yes (adding more "locale" to a new feature)
Deprecations? no
Tickets -
License MIT
Doc PR

Fabbot reports are not relevant

@carsonbot carsonbot added this to the 6.2 milestone Aug 12, 2022
@ro0NL ro0NL mentioned this pull request Aug 17, 2022
Merged
nicolas-grekas
nicolas-grekas approved these changes Aug 17, 2022
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed an implementation to provide reverse-transliteration for github / slack.
There are now 4 possible ids to use the corresponding maps: emoji-github, emoji-slack, github-emoji, slack-emoji.

@nicolas-grekas
Copy link
Member

Thank you @lyrixx.

@nicolas-grekas nicolas-grekas mentioned this pull request Aug 17, 2022
Closed
@nicolas-grekas nicolas-grekas merged commit 68fe153 into symfony:6.2 Aug 17, 2022
@lyrixx lyrixx deleted the intl-trans-emoji-gh branch August 17, 2022 09:48
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug Feature Intl Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
3 participants
@lyrixx @nicolas-grekas @carsonbot