[Notifier] Add Chatwork Notifier Bridge #47373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
requested changes
Aug 26, 2022
| try { | ||
| $statusCode = $response->getStatusCode(); | ||
| } catch (TransportExceptionInterface $e) { | ||
| throw new TransportException('Could not reach the remote Discord server.', $response, 0, $e); |
There was a problem hiding this comment.
Suggested change
| throw new TransportException('Could not reach the remote Discord server.', $response, 0, $e); | |
| throw new TransportException('Could not reach the remote Chatwork server.', $response, 0, $e); |
| $originalContent = $message->getSubject(); | ||
| $result = $response->toArray(false); | ||
| $errors = $result['errors']; | ||
| throw new TransportException(sprintf('Unable to post the Chatwork message: "%s" (%d: "%s").', $originalContent, $statusCode, implode(', ', $errors)), $response); |
There was a problem hiding this comment.
Suggested change
| throw new TransportException(sprintf('Unable to post the Chatwork message: "%s" (%d: "%s").', $originalContent, $statusCode, implode(', ', $errors)), $response); | |
| throw new TransportException(sprintf('Unable to post the Chatwork message: "%s" (%d: %s).', $originalContent, $statusCode, implode(', ', $errors)), $response); |
If you received an error from fabbot here, that's a false positive.
| @@ -0,0 +1,19 @@ | |||
| Chatwork Notifier | |||
| =============== | |||
There was a problem hiding this comment.
Suggested change
| =============== | |
| ================= |
|
@fabpot Thank you, I applied those suggestions. |
fabpot
approved these changes
Aug 26, 2022
571eda6 to
6dcab51
Compare
|
Thank you @Ippey. |
|
@fabpot Created PR. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Chatwork Notifier Bridge.
Chatwork is one of the popular chat tools in Japan.
This bridge allows sending messages to Chatwork via Chatwork API.