Skip to content

[Messenger] add dedicated method for disabling instead of passing boolean flags #47460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2022
Merged

[Messenger] add dedicated method for disabling instead of passing boolean flags #47460

merged 1 commit into from
Oct 1, 2022

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Sep 2, 2022

Q A
Branch? 6.2
Bug fix? no
New feature? yes (changes #39622)
Deprecations? no
Tickets
License MIT
Doc PR

@xabbuh xabbuh added this to the 6.2 milestone Sep 2, 2022
@carsonbot
Copy link

Hey!

I think @Jeroeny has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@xabbuh
Copy link
Member Author

xabbuh commented Sep 12, 2022 •
edited
Loading

ping @lyrixx What do you think as you introduced the initial method (in #39622)?

@lyrixx
Copy link
Member

lyrixx commented Sep 12, 2022

I Don't have any recommendations here... It's up to you 👍🏼

@fabpot
Copy link
Member

fabpot commented Oct 1, 2022

Thank you @xabbuh.

@fabpot fabpot mentioned this pull request Oct 1, 2022
Closed
@fabpot fabpot merged commit 180c4f8 into symfony:6.2 Oct 1, 2022
@xabbuh xabbuh deleted the pr-39622 branch October 2, 2022 08:19
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@lyrixx lyrixx lyrixx left review comments

@fabpot fabpot fabpot approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Feature Messenger Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @carsonbot @lyrixx @fabpot @nicolas-grekas @chalasr