[HttpKernel] Make Logger implement DebugLoggerInterface #47483
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
db1fa17 to
d19456b
Compare
d19456b to
3391283
Compare
lyrixx
reviewed
Sep 13, 2022
aaf7197 to
438b512
Compare
|
Thanks for your feedback 🙏 I updated the PR accordingly. |
d59e2fb to
9a9cc67
Compare
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddDebugLogProcessorPass.php
Outdated
Show resolved
Hide resolved
MatTheCat
added a commit
to MatTheCat/symfony
that referenced
this pull request
Oct 17, 2022
9a9cc67 to
c1a66d6
Compare
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddDebugLogProcessorPass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddDebugLogProcessorPass.php
Outdated
Show resolved
Hide resolved
MatTheCat
added a commit
to MatTheCat/symfony
that referenced
this pull request
Oct 17, 2022
MatTheCat
added a commit
to MatTheCat/symfony
that referenced
this pull request
Oct 17, 2022
MatTheCat
added a commit
to MatTheCat/symfony
that referenced
this pull request
Oct 17, 2022
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddDebugLogProcessorPass.php
Outdated
Show resolved
Hide resolved
MatTheCat
added a commit
to MatTheCat/symfony
that referenced
this pull request
Oct 17, 2022
66982e0 to
0c8604c
Compare
nicolas-grekas
approved these changes
Oct 17, 2022
fabpot
approved these changes
Oct 20, 2022
|
Thank you @MatTheCat. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a new project from a skeleton I was surprised not to see any log in the profiler and error pages. Turns out this depends of the logger implementing
DebugLoggerInterfacebut AFAIK this only happen in Monolog’s bridge.Given the API makes it weird to implement it in userland (see #47396) would it make sense to provide one by default?